";
open(STATUS, "$config{'shorewall'} check 2>&1 |");
@@ -18,5 +19,6 @@ if ($?) {
else {
print "$text{'check_ok'}\n";
}
+
&ui_print_footer("", $text{'index_return'});
diff --git a/shorewall/dump.cgi b/shorewall/dump.cgi
index 7f2e5248d..f3f687259 100755
--- a/shorewall/dump.cgi
+++ b/shorewall/dump.cgi
@@ -4,6 +4,7 @@
require './shorewall-lib.pl';
&ui_print_header(undef, $text{'dump_title'}, "");
+
print "";
open(DUMP, "$config{'shorewall'} dump 2>&1 |");
while() {
@@ -11,5 +12,6 @@ while() {
}
close(DUMP);
print " \n";
+
&ui_print_footer("", $text{'index_return'});
diff --git a/shorewall/edit.cgi b/shorewall/edit.cgi
index ae865abfe..aa7fea0f9 100755
--- a/shorewall/edit.cgi
+++ b/shorewall/edit.cgi
@@ -23,33 +23,26 @@ else {
$row = $table[$in{'idx'}];
}
-print "
\n";
&ui_print_footer("list.cgi?table=$in{'table'}", $text{$in{'tableclean'}."_return"});
diff --git a/shorewall/list.cgi b/shorewall/list.cgi
index d0809208c..74f8666fc 100755
--- a/shorewall/list.cgi
+++ b/shorewall/list.cgi
@@ -56,9 +56,10 @@ if (@table) {
local @tds;
if ($t[0] =~ /\??COMMENT/) {
# Special case - a comment line
- push(@cols, "".join(" ", @t[1..$#t]).
- "" );
+ push(@cols, &ui_link(
+ "editcmt.cgi?table=".&urlize($in{'table'}).
+ "&idx=".&urlize($i),
+ "".join(" ", @t[1..$#t]).""));
@tds = ( "width=5", "colspan=".scalar(@colnames) );
}
else {
@@ -68,7 +69,9 @@ if (@table) {
}
for($j=0; $j<@colnames; $j++) {
if ($j == 0) {
- $lnk = &ui_link("edit.cgi?table=$in{'table'}&idx=$i",$t[$j]);
+ $lnk = &ui_link(
+ "edit.cgi?table=".&urlize($in{'table'}).
+ "&idx=".&urlize($i), $t[$j]);
}
else {
$lnk = $t[$j];
@@ -78,26 +81,20 @@ if (@table) {
@tds = ( "width=5" );
}
if (@table > 1) {
- $mover = "";
- if ($i == 0) {
- $mover .= "
";
- }
- else {
- $mover .= &ui_link("up.cgi?table=$in{'table'}&idx=$i","
")."\n";
- }
- if ($i == $#table) {
- $mover .= "
";
- }
- else {
- $mover .= &ui_link("down.cgi?table=$in{'table'}&idx=$i","
")."\n";
- }
- push(@cols, $mover);
+ push(@cols, &ui_up_down_arrows(
+ "up.cgi?table=".&urlize($in{'table'})."&idx=".&urlize($i),
+ "down.cgi?table=".&urlize($in{'table'})."&idx=".&urlize($i),
+ $i > 0, $i != $#table,
+ "images/up.gif", "images/down.gif"));
}
- push(@cols,
- "".
- "
\n".
- "".
- "
\n");
+ push(@cols, &ui_link(
+ "edit.cgi?table=".&urlize($in{'table'}).
+ "&new=1&before=".&urlize($i),
+ "
").
+ &ui_link(
+ "edit.cgi?table=".&urlize($in{'table'}).
+ "&new=1&after=".&urlize($i),
+ "
"));
print &ui_checked_columns_row(\@cols, \@tds, "d", $i);
}
print &ui_columns_end();