From db0db372f51937d67da1de65bdbeef50f269370e Mon Sep 17 00:00:00 2001 From: Koushik Dutta Date: Tue, 19 Apr 2022 09:15:06 -0700 Subject: [PATCH] homekit: fix remote detection --- plugins/homekit/package-lock.json | 4 ++-- plugins/homekit/package.json | 2 +- plugins/homekit/src/types/camera/camera-utils.ts | 8 ++++++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/plugins/homekit/package-lock.json b/plugins/homekit/package-lock.json index d41c11702..6aa6ec11b 100644 --- a/plugins/homekit/package-lock.json +++ b/plugins/homekit/package-lock.json @@ -1,12 +1,12 @@ { "name": "@scrypted/homekit", - "version": "0.0.244", + "version": "0.0.245", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@scrypted/homekit", - "version": "0.0.244", + "version": "0.0.245", "dependencies": { "@koush/qrcode-terminal": "^0.12.0", "check-disk-space": "^3.3.0", diff --git a/plugins/homekit/package.json b/plugins/homekit/package.json index 0eb614540..0de3a5100 100644 --- a/plugins/homekit/package.json +++ b/plugins/homekit/package.json @@ -44,5 +44,5 @@ "@types/node": "^14.17.9", "@types/url-parse": "^1.4.3" }, - "version": "0.0.244" + "version": "0.0.245" } diff --git a/plugins/homekit/src/types/camera/camera-utils.ts b/plugins/homekit/src/types/camera/camera-utils.ts index 6ad9182b1..8ade80ecb 100644 --- a/plugins/homekit/src/types/camera/camera-utils.ts +++ b/plugins/homekit/src/types/camera/camera-utils.ts @@ -56,8 +56,12 @@ export async function getStreamingConfiguration(device: ScryptedDevice & VideoCa catch (e) { } - // Have only ever seen 20 and 60 sent here. 60 is remote stream and watch. - const isLowBandwidth = request.audio.packet_time > 20; + // Observed packet times: + // Opus (Local): 20 + // Opus (Remote): 60 + // AAC-ELD (Local): 30 + // AAC-ELD (Remote): 60 + const isLowBandwidth = request.audio.packet_time >= 60; // watch is 448x368 and requests 320x240, everything else is > ~1280... // future proof-ish for higher resolution watch.