From cbd11908af6eb6806aea47fc18a3e771c1ffc080 Mon Sep 17 00:00:00 2001 From: Koushik Dutta Date: Wed, 10 Apr 2024 11:36:45 -0700 Subject: [PATCH] homekit: fix aac transcoding for silent audio --- plugins/homekit/package-lock.json | 4 ++-- plugins/homekit/package.json | 2 +- plugins/homekit/src/types/camera/camera-recording.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/homekit/package-lock.json b/plugins/homekit/package-lock.json index aedb2ed58..f38f01076 100644 --- a/plugins/homekit/package-lock.json +++ b/plugins/homekit/package-lock.json @@ -1,12 +1,12 @@ { "name": "@scrypted/homekit", - "version": "1.2.46", + "version": "1.2.48", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@scrypted/homekit", - "version": "1.2.46", + "version": "1.2.48", "dependencies": { "@koush/werift-src": "file:../../external/werift", "check-disk-space": "^3.4.0", diff --git a/plugins/homekit/package.json b/plugins/homekit/package.json index 363206d3e..e3a0a71e9 100644 --- a/plugins/homekit/package.json +++ b/plugins/homekit/package.json @@ -1,6 +1,6 @@ { "name": "@scrypted/homekit", - "version": "1.2.46", + "version": "1.2.48", "description": "HomeKit Plugin for Scrypted", "scripts": { "scrypted-setup-project": "scrypted-setup-project", diff --git a/plugins/homekit/src/types/camera/camera-recording.ts b/plugins/homekit/src/types/camera/camera-recording.ts index 1a8a514b7..ddc57ee5a 100644 --- a/plugins/homekit/src/types/camera/camera-recording.ts +++ b/plugins/homekit/src/types/camera/camera-recording.ts @@ -194,7 +194,7 @@ export async function* handleFragmentsRequests(streamId: number, device: Scrypte } let audioArgs: string[]; - if (transcodeRecording || isDefinitelyNotAAC || debugMode.audio) { + if (!noAudio && (transcodeRecording || isDefinitelyNotAAC || debugMode.audio)) { if (!(transcodeRecording || debugMode.audio)) console.warn('Recording audio is not explicitly AAC, forcing transcoding. Setting audio output to AAC is recommended.', audioCodec);