From 719dfd2f2425bde79a554fc2221bf3f5ca6f9ea9 Mon Sep 17 00:00:00 2001 From: Koushik Dutta Date: Wed, 13 Nov 2024 09:01:05 -0800 Subject: [PATCH] server: plugin device deletion crash fix --- server/src/plugin/plugin-host-api.ts | 2 +- server/src/runtime.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/server/src/plugin/plugin-host-api.ts b/server/src/plugin/plugin-host-api.ts index 08893ac13..2c5cab70e 100644 --- a/server/src/plugin/plugin-host-api.ts +++ b/server/src/plugin/plugin-host-api.ts @@ -186,7 +186,7 @@ export class PluginHostAPI extends PluginAPIManagedListeners implements PluginAP async requestRestart() { const logger = await this.getLogger(undefined); - logger.log('i', 'plugin restart was requested'); + logger?.log('i', 'plugin restart was requested'); return this.restartDebounced(); } diff --git a/server/src/runtime.ts b/server/src/runtime.ts index 35af2a897..4ea6e1feb 100644 --- a/server/src/runtime.ts +++ b/server/src/runtime.ts @@ -231,6 +231,8 @@ export class ScryptedRuntime extends PluginHttp { } getDeviceLogger(device: PluginDevice): Logger { + if (!device) + return; return this.devicesLogger.getLogger(device._id, getState(device, ScryptedInterfaceProperty.name)); }