From 6dbec2b9235f0976532bbf786da8592f3046682a Mon Sep 17 00:00:00 2001
From: Koushik Dutta <koush@Koushik-MacStudio.localdomain>
Date: Sun, 11 Sep 2022 21:53:26 -0700
Subject: [PATCH] core: fix button clicks

---
 plugins/core/ui/src/interfaces/Settings.vue | 28 ++++++++++++++++++---
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/plugins/core/ui/src/interfaces/Settings.vue b/plugins/core/ui/src/interfaces/Settings.vue
index 8c5626eb1..cf6b594c0 100644
--- a/plugins/core/ui/src/interfaces/Settings.vue
+++ b/plugins/core/ui/src/interfaces/Settings.vue
@@ -1,8 +1,9 @@
 <template>
   <v-card>
     <CardTitle v-if="!noTitle">Settings</CardTitle>
-    <v-flex xs12 v-if="showChips" class="pt-0">
-      <v-chip-group mandatory active-class="deep-purple accent-4 white--text" column v-model="settingsGroupName">
+    <v-flex xs12 v-if="showChips" >
+      <v-chip-group class="pt-0" mandatory active-class="deep-purple accent-4 white--text" column v-model="settingsGroupName"
+        v-if="Object.entries(settingsGroups).length < 4 || true">
         <v-chip small :value="key" v-for="[key] of Object.entries(settingsGroups)" :key="key">
           {{ key.replace("Settings", "") || "General" }}
         </v-chip>
@@ -10,6 +11,9 @@
           Integrations and Extensions
         </v-chip>
       </v-chip-group>
+      <v-select v-else dense filled outlined :items="selectGroupNames" v-model="settingsGroupName" :hide-details="true">
+
+      </v-select>
     </v-flex>
 
     <v-divider v-if="showChips"></v-divider>
@@ -21,8 +25,8 @@
         setting.value.type === 'device' ||
         setting.value.type === 'interface' ||
         !setting.value.multiple" v-model="setting.value" @input="onInput"
-          :device="setting.value.type === 'clippath' ? device : undefined"></Setting>
-        <SettingMultiple v-else v-model="setting.value" :device="setting.value.type === 'clippath' ? device : undefined"
+          :device="needsDevice(setting) ? device : undefined"></Setting>
+        <SettingMultiple v-else v-model="setting.value" :device="needsDevice(setting) ? device : undefined"
           @input="onInput">
         </SettingMultiple>
       </div>
@@ -74,6 +78,19 @@ export default {
     this.refresh();
   },
   computed: {
+    selectGroupNames() {
+      const ret = Object.keys(this.settingsGroups).map(key => ({
+        text: key.replace("Settings", "") || "General",
+        value: key,
+      }));
+      if (this.availableMixins.length) {
+        ret.push({
+          value: 'extensions',
+          text: 'Integrations and Extensions',
+        })
+      }
+      return ret;
+    },
     ScryptedInterface() {
       return ScryptedInterface;
     },
@@ -111,6 +128,9 @@ export default {
         settings: this.settings.map((setting) => setting.value),
       };
     },
+    needsDevice(setting) {
+      return setting.value.type === 'clippath' || setting.value.type === 'button';
+    },
     async refresh() {
       let settings;
       if (!this.device) {