From 5f040f5ff41af6c2308891032f3af546ed3797f5 Mon Sep 17 00:00:00 2001 From: Koushik Dutta Date: Thu, 2 Apr 2026 13:20:13 -0700 Subject: [PATCH] strictNullChecks: fix core utilities - Change Express sendFile root from null to undefined - Add undefined to RefreshPromise.promise type - Add undefined to debouncer current promise type --- server/src/http-interfaces.ts | 2 +- server/src/promise-utils.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/src/http-interfaces.ts b/server/src/http-interfaces.ts index 808878950..d1d64db01 100644 --- a/server/src/http-interfaces.ts +++ b/server/src/http-interfaces.ts @@ -63,7 +63,7 @@ export class HttpResponseImpl implements HttpResponse { // prefer etag this.res.sendFile(filePath, { - root: null, + root: undefined, dotfiles: 'allow', cacheControl: false, }); diff --git a/server/src/promise-utils.ts b/server/src/promise-utils.ts index 8f5fa27ea..29de7efae 100644 --- a/server/src/promise-utils.ts +++ b/server/src/promise-utils.ts @@ -1,5 +1,5 @@ export interface RefreshPromise { - promise: Promise; + promise: Promise | undefined; cacheDuration: number; } @@ -66,12 +66,12 @@ export function timeoutFunction(timeout: number, f: (isTimedOut: () => boolea } export function createPromiseDebouncer() { - let current: Promise; + let current: Promise | undefined; return (func: () => Promise): Promise => { if (!current) - current = func().finally(() => current = undefined); - return current; + current = func().finally(() => current = undefined as unknown as Promise); + return current!; } }