michael/scrypted
1
0
Fork 0
mirror of https://github.com/koush/scrypted.git synced 2026-04-25 09:20:24 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

server: sketchy check to determine if buffer is pool buffer

Browse Source
This commit is contained in:
Koushik Dutta
2024-08-19 16:04:38 -07:00
parent 86dcb66e6a
commit 0ebbc5ea8f
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/src/plugin/runtime/node-thread-worker.ts
View File

@@ -12,9 +12,14 @@ class BufferTransfer implements RpcSerializer {
if (!serializationContext)
return this.bufferSerializer.serialize(value);
// must create a copy. Buffers as allocated by node are not transferable.
const ab = value.buffer.slice(value.byteOffset, value.byteOffset + value.byteLength);
value = Buffer.from(ab);
// node may used pooled buffers for Buffer.allocUnsafe, Buffer.from, and other calls.
// these buffers will be smaller than Buffer.poolSize.
// In these instances, do not transfer the buffer, as it may not be transferible.
// create a copy so it can be safely transfered.
if (value.buffer.byteLength <= Buffer.poolSize) {
const ab = value.buffer.slice(value.byteOffset, value.byteOffset + value.byteLength);
value = Buffer.from(ab);
}
serializationContext.transferList ||= [];
const transferList: worker_threads.TransferListItem[] = serializationContext.transferList;