From acb0eac3498f82bb26f4ae05764fca1491cd3f99 Mon Sep 17 00:00:00 2001 From: base47 Date: Sun, 15 Feb 2026 20:42:16 +0100 Subject: [PATCH] Address the PR comments from base47 --- battery.sh | 4 ++-- setup.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/battery.sh b/battery.sh index b0113d4..dafa84a 100755 --- a/battery.sh +++ b/battery.sh @@ -670,9 +670,9 @@ fi # Update helper for Terminal users if [[ "$action" == "update" ]]; then - # Temporarily support the 'silent' setting for backward compatibility with older UI versions. + # The older GUI versions 1_3_2 and below can not run silent passwordless update and + # will complain with alert. Just exit with success and let them update themselves. if [[ "$setting" == "silent" ]]; then - sudo -n $battery_binary update_silent exit 0 fi diff --git a/setup.sh b/setup.sh index af527fe..afad9f2 100755 --- a/setup.sh +++ b/setup.sh @@ -95,7 +95,7 @@ sudo chmod 755 "$(dirname "$launch_agent_plist")" sudo chown -f $calling_user "$launch_agent_plist" echo "[ 8 ] Setup visudo configuration" -sudo $binfolder/battery visudo $calling_user +sudo $binfolder/battery visudo sudo chown -R $calling_user $configfolder # Remove tempfiles