mirror of
https://github.com/dutchcoders/transfer.sh.git
synced 2026-02-03 06:03:25 +00:00
Feature: skip auth from specific IP #97
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @michaelscl on GitHub.
Hi,
We use the service to exchange files between customers. It would make the work easier to not require upload authentication when accessing from defined IPs.
What do you think?
best regards
Michaels
@toastie89 commented on GitHub:
@aspacca, thanks for the workaround!
Having one container with
HTTP_AUTH_USERand another withIP_WHITELISTpointing both to the same storage works fine.@paolafrancesca commented on GitHub:
@michaelscl I see some value indeed, while I'm not sure about the extra complexity in configuration
just an idea at infra level: have you thought about hosting two instances pointing at the same storage, one with and one without upload authentication, and route to the second from the IPs you'd like to whitelist?
@paolafrancesca commented on GitHub:
hello @michaelscl where you able to try this solution?
@toastie89 commented on GitHub:
@aspacca nice idea, I will give it a try
@michaelscl commented on GitHub:
@aspacca Yes, this is a partial solution for me. For the convenience of uploading from our lan, I didn't want to use HTTP_AUTH at all.
I use the program through a reverse proxy and sometimes I have a problem with HTTP_AUTH - the login window doesn't pop up and it shows an error.
@paolafrancesca commented on GitHub:
@michaelscl do you think the provided solution at infra level is satisfying?
I will look into adding
NO_HTTP_AUTH_FROM_WHITELISTin case@paolafrancesca commented on GitHub:
@michaelscl
as I said my main concern was about complexity of the configuration.
I think a solution migth be to add
NO_HTTP_AUTH_FROM_WHITELIST@paolafrancesca commented on GitHub:
I was talking about this solution:
@michaelscl commented on GitHub:
I think YES, if the implementation is easy.
@michaelscl commented on GitHub:
Yes, but this is such a noodle solution. As I wrote. This whole thing is just a suggestion. It's up to you if you decide to implement it or not.
@paolafrancesca commented on GitHub:
@michaelscl #538 in the case an IP already passed the IP filters authorise automatically for upload
not sure how useful it is. if you currently use the ip filter but you still set an http auth it means you want to differentiate two sets of ip filter lists: the one for get request and the one for upload requests
indeed I'm going to refactor the code in PR and provides a separated http auth ip filter lists because it is the only thing that makes sense