Download button fails for names with hash mark (#) #51

Open
opened 2026-01-19 18:28:45 +00:00 by michael · 2 comments
Owner

Originally created by @Ulysses1337 on GitHub.

Mirror of #213 on the web frontend. If I upload foo#1.txt with curl, the download button gives a 404 because the get link has an unencoded #, so the server will not find /get/hash/foo.

If I upload the same file with the frontend, the download button works, but the filename is truncated at the #.

Originally created by @Ulysses1337 on GitHub. Mirror of #213 on the web frontend. If I upload `foo#1.txt` with curl, the download button gives a 404 because the `get` link has an unencoded `#`, so the server will not find `/get/hash/foo`. If I upload the same file with the frontend, the download button works, but the filename is truncated at the `#`.
Author
Owner

@paolafrancesca commented on GitHub:

@Ulysses1337

thanks for reporting the issue, I was able to reproduce

as you mentionedm for the curl upload with frontend giving 404 the problem is that the file is uploaded as foo%231.txt while the link points to foo#1.txt. I will look into urlencoding the filename in the frontend link. minor thing is that will produce urlencoded url probably for every non-ascii chars, including non latin alphabets

I will look into the js for the part on the frontend truncating at #

@paolafrancesca commented on GitHub: @Ulysses1337 thanks for reporting the issue, I was able to reproduce as you mentionedm for the curl upload with frontend giving 404 the problem is that the file is uploaded as `foo%231.txt` while the link points to `foo#1.txt`. I will look into urlencoding the filename in the frontend link. minor thing is that will produce urlencoded url probably for every non-ascii chars, including non latin alphabets I will look into the js for the part on the frontend truncating at `#`
Author
Owner

@paolafrancesca commented on GitHub:

adding that deleting from frontend is broken as well

@paolafrancesca commented on GitHub: adding that deleting from frontend is broken as well
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dutchcoders/transfer.sh#51