mirror of
https://github.com/dutchcoders/transfer.sh.git
synced 2026-02-03 06:03:25 +00:00
Download button fails for names with hash mark (#) #51
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ulysses1337 on GitHub.
Mirror of #213 on the web frontend. If I upload
foo#1.txtwith curl, the download button gives a 404 because thegetlink has an unencoded#, so the server will not find/get/hash/foo.If I upload the same file with the frontend, the download button works, but the filename is truncated at the
#.@paolafrancesca commented on GitHub:
@Ulysses1337
thanks for reporting the issue, I was able to reproduce
as you mentionedm for the curl upload with frontend giving 404 the problem is that the file is uploaded as
foo%231.txtwhile the link points tofoo#1.txt. I will look into urlencoding the filename in the frontend link. minor thing is that will produce urlencoded url probably for every non-ascii chars, including non latin alphabetsI will look into the js for the part on the frontend truncating at
#@paolafrancesca commented on GitHub:
adding that deleting from frontend is broken as well