mirror of
https://github.com/dutchcoders/transfer.sh.git
synced 2026-02-03 14:13:26 +00:00
Version not set in Docker container? #42
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @luckman212 on GitHub.
Hi, and 🙏 thank you for transfer.sh !
I am running it in Docker, and wanted to make a simple update notifier when new releases are tagged. So I wanted a way to return the current running version from a script.
Looking at the source, it seems that there is a
versioncli argument that should output the running version29d93c6da0/cmd/cmd.go (L317)but when I tried it, it's empty:
Am I doing something wrong? Is there another way to retrieve the current version?
@luckman212 commented on GitHub:
Is there any workaround you could suggest? What about just hardcoding the current version in a
VERSIONfile and having the Dockerfile read from that?@paolafrancesca commented on GitHub:
hello @luckman212 , thanks for reporting this bug
the problem is that the build command on docker file does not work properly, with
git describe --tagsfailing since it's run not inside a git repo@amayer5125 commented on GitHub:
I believe the issue is that ".git" is in .dockerignore. When
COPY . .is run, the files in .dockerignore are skipped. Since the .git directory isn't copied into the docker image the command that sets the version (git describe --tags) fails. Removing ".git" from .dockerignore fixes the issue for me.I don't believe removing .git from the .dockerignore file is the correct solution for the repo though because then the container will be larger.
@luckman212 commented on GitHub:
Ok I'll look into that, thanks
@stefanbenten commented on GitHub:
You can use watchtower to achieve the same without having to write a script :)
@paolafrancesca commented on GitHub:
the final image is based on scratch, we can remove .git from the .dockerignore without having a bigger image. the .git folder will be copied only in the build stage of the image