mirror of
https://github.com/dutchcoders/transfer.sh.git
synced 2026-02-03 06:03:25 +00:00
Fails on uploading favicon.ico #272
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kade-robertson on GitHub.
When uploading a file named
favicon.icoto transfer.sh through the website, you get a bunch of garbled mess (I believe it's the data for your favicon) instead of a link to the upload.This is presumably because it makes a PUT request to
https://transfer.sh/favicon.icowhich isn't/shouldn't be allowed. This is on Chrome 73.0.3683.86 on Mac OS 10.14.3:When uploading using
curlit's not quite as bad, since you receive a warning:And if you follow the warning, you get:
Which ends up being your favicon (as suspected):
There should probably be some kind of warning if uploading a file that's invalid (or some way to handle this special case, i.e. not serving your favicon on a PUT if that's possible).
@paolafrancesca commented on GitHub:
I will fix limiting
http.FileServerhandler only for GET requests. Anyway it is unlikely to see the fix on http://transfer.sh :)