mirror of
https://github.com/dutchcoders/transfer.sh.git
synced 2026-02-03 14:13:26 +00:00
Multi-architecture Docker image #206
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gabriel-duque on GitHub.
Hello,
I have been using the
transfer.shDocker image for quite some time now.I would like to use it on arm64 but the image you publish is only amd64.
I might be wrong about this but from what I saw, supporting other architectures should be pretty straightforward and easy using
buildxas you don't rely on other images than thegolangone and that one is already multi-architecture.Normally, you shouldn't even have to touch the source code or Dockerfile, just instruct Docker to build a multi-platform image and every thing else should be the same.
@gabriel-duque commented on GitHub:
@aspacca I just created a PR to add a workflow to build the images.
The currrent build is going to fail at the push step because of the missing secrets, but the images will build (hopefully) just fine.
@gabriel-duque commented on GitHub:
I just tried your image
dutchoders/transfer.sh:ISSUE-313-aarch64with sha256 = b8bab5.... and I am getting an exec format error so something went wrong and it isn't the right architecture 😢I just built images for armv7, armv8(aarch64), amd64 and i386 and they seem to be working.
I only tested the aarch64 one but I can upload a file and get it back and the logs seem happy.
I put them here.
I didn't try armv6, ppc64le or s390x because I have already had problems when compiling static go binaries with them in the past (especially ones using the
netmodule).In order to produce them I simply did this (my
buildxis already configured but it is the default config):EDIT: I just tested armv6, ppc64le and s390x and none of them build.
Other than that, I tested i386 and armv7 and they seem to work well (could upload then download a file on local storage).
@paolafrancesca commented on GitHub:
hi @zuh0 docker hub doesn't provide an automatic way to build for multiple architectures
I've used https://github.com/rmoriz/multiarch-test process to achieve (probably qemu not needed since go can cross compile)
can you test the images built?
https://hub.docker.com/layers/dutchcoders/transfer.sh/ISSUE-313/images/sha256-f114f3dbaa1b3b7a1fc7816acfdfaeba6a0585d75e1b9798219171f7730abb50?context=repo
@paolafrancesca commented on GitHub:
@zuh0 thanks
see https://github.com/dutchcoders/transfer.sh/pull/316 for using the buildx github action
anyway I cannot yet push to docker hub since I need access to project settings from the original maintainer. I've just sent him an email
@gabriel-duque commented on GitHub:
hey @aspacca ,
thanks for the answer !
I will try this image and tell you if it works well. since that is what I use, I can only test the local storage driver using the arm64 architecture for now but that can already be a nice test.
the
moritz/multiarch-testrepo looks nice !just for the record: I have a setup to automatically build multi-artchitecture docker images in a GithubAction in one of my personal repos and the setup was a breeze using this action.
this might be the option implying the least efforts/changes.