dutchcoders/transfer.sh
1
0
Fork 0
mirror of https://github.com/dutchcoders/transfer.sh.git synced 2026-02-06 07:22:17 +00:00
Code Issues 48 Actions Packages Projects Releases Wiki Activity

Bug: Error 404 when try to delete file uploaded via zsh function #155

New Issue
Closed
opened 2026-01-19 18:29:12 +00:00 by michael · 9 comments
michael commented 2026-01-19 18:29:12 +00:00
Owner
Copy Link

Originally created by @slmnsh on GitHub.

First of it doesn't give any deletion token when we upload file via zsh function/plugin
Another thing is it shows delete button whenever someone visits the link and it prompts for deletion token but when we click on confirm button it shows "Error (404) during deletion of file"

So, I'll suggest to remove delete button completely. and also I want to know when files deleted from the server?

Originally created by @slmnsh on GitHub. First of it doesn't give any deletion token when we upload file via zsh function/plugin Another thing is it shows delete button whenever someone visits the link and it prompts for deletion token but when we click on confirm button it shows "Error (404) during deletion of file" So, I'll suggest to remove delete button completely. and also I want to know when files deleted from the server?
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@paolafrancesca commented on GitHub:

We won't remove the delete button, since it's working properly: you have to provide the deletion token, as stated in the hint.
When you click the button a DELETE request is made to token/filename/deletionToken, if the deletion token is wrong or empty, the request result in a 404 (not found)

Deletion token is returned on upload in the header X-Url-Delete, zsh function doesn't print it: I never used zsh so I wouldn't be able to modify. Any external PR to enanche the zsh function is welcome

@paolafrancesca commented on GitHub: We won't remove the delete button, since it's working properly: you have to provide the deletion token, as stated in the hint. When you click the button a `DELETE` request is made to `token/filename/deletionToken`, if the deletion token is wrong or empty, the request result in a 404 (not found) Deletion token is returned on upload in the header `X-Url-Delete`, zsh function doesn't print it: I never used zsh so I wouldn't be able to modify. Any external PR to enanche the zsh function is welcome
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@slmnsh commented on GitHub:

So I think it's useless to show that delete button

On Wed, Sep 15, 2021, 1:51 AM Andrea Spacca @.***>
wrote:

I want to know when files deleted from the server

every server can setup it's own purge period.
If the server you've uploaded to is using v1.3.0 the purge time is
reported in the homepage

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dutchcoders/transfer.sh/issues/409#issuecomment-919484591,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGN64PCIV2KWJJJXJIC3TGLUB6VDVANCNFSM5EAW5QEQ
.

@slmnsh commented on GitHub: So I think it's useless to show that delete button On Wed, Sep 15, 2021, 1:51 AM Andrea Spacca ***@***.***> wrote: > I want to know when files deleted from the server > > every server can setup it's own purge period. > If the server you've uploaded to is using v1.3.0 the purge time is > reported in the homepage > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/dutchcoders/transfer.sh/issues/409#issuecomment-919484591>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AGN64PCIV2KWJJJXJIC3TGLUB6VDVANCNFSM5EAW5QEQ> > . >
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@slmnsh commented on GitHub:

Where can I find the script for transfer cli command?

@slmnsh commented on GitHub: Where can I find the script for transfer cli command?
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@slmnsh commented on GitHub:

Deletion token is returned on upload in the header X-Url-Delete, zsh function doesn't print it: I never used zsh so I wouldn't be able to modify. Any external PR to enanche the zsh function is welcome

Okay, I'll try that. Also when you click confirm again and again it appends the error into same error instead of replacing it completely.

@slmnsh commented on GitHub: > Deletion token is returned on upload in the header `X-Url-Delete`, zsh function doesn't print it: I never used zsh so I wouldn't be able to modify. Any external PR to enanche the zsh function is welcome Okay, I'll try that. Also when you click confirm again and again it appends the error into same error instead of replacing it completely.
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@paolafrancesca commented on GitHub:

I want to know when files deleted from the server

every server can setup it's own purge period.
If the server you've uploaded to is using v1.3.0 the purge time is reported in the homepage

@paolafrancesca commented on GitHub: > I want to know when files deleted from the server every server can setup it's own purge period. If the server you've uploaded to is using `v1.3.0` the purge time is reported in the homepage
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@corporateuser commented on GitHub:

Some command line clients do not print headers by default, please consider to return JSON object instead of a simple string:

{
  "downloadUrl": "string",
  "deletionUrl": "string"
}
@corporateuser commented on GitHub: Some command line clients do not print headers by default, please consider to return JSON object instead of a simple string: ```JSON { "downloadUrl": "string", "deletionUrl": "string" } ```
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@imTHAI commented on GitHub:

Deletion token is returned on upload in the header X-Url-Delete, zsh function doesn't print it: I never used zsh so I wouldn't be able to modify. Any external PR to enanche the zsh function is welcome

That's why ! I was searching where the hell I should be supposed to have received it. Maybe it would be good to warm people somewhere in the README.md text, zsh is even the default shell under MacOS

@imTHAI commented on GitHub: > Deletion token is returned on upload in the header `X-Url-Delete`, zsh function doesn't print it: I never used zsh so I wouldn't be able to modify. Any external PR to enanche the zsh function is welcome That's why ! I was searching where the hell I should be supposed to have received it. Maybe it would be good to warm people somewhere in the README.md text, zsh is even the default shell under MacOS
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@paolafrancesca commented on GitHub:

@corporateuser sorry, that will be a breaking change

@paolafrancesca commented on GitHub: @corporateuser sorry, that will be a breaking change
michael commented 2026-01-19 18:29:13 +00:00
Author
Owner
Copy Link

@slmnsh commented on GitHub:

Also when you click confirm again and again it appends the error into same error instead of replacing it completely.

nvm I made PR on transfer.sh-web repo for that fix

@slmnsh commented on GitHub: >Also when you click confirm again and again it appends the error into same error instead of replacing it completely. nvm I made PR on transfer.sh-web repo for that fix
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
docker
enhancement
hacktoberfest
help wanted
invalid
question
storage provider
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
michael
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dutchcoders/transfer.sh#155
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?