mirror of
https://github.com/SigNoz/signoz.git
synced 2026-04-27 06:00:31 +01:00
Some checks failed
build-staging / prepare (push) Has been cancelled
build-staging / js-build (push) Has been cancelled
build-staging / go-build (push) Has been cancelled
build-staging / staging (push) Has been cancelled
Release Drafter / update_release_draft (push) Has been cancelled
* feat(instrumentation): add OTel exception semantic convention log handler
Add a loghandler.Wrapper that enriches error log records with OpenTelemetry
exception semantic convention attributes (exception.type, exception.code,
exception.message, exception.stacktrace).
- Add errors.Attr() helper for standardized error logging under "exception" key
- Add exception log handler that replaces raw error attrs with structured group
- Wire exception handler into the instrumentation SDK logger chain
- Remove LogValue() from errors.base as the handler now owns structuring
* refactor: replace "error", err with errors.Attr(err) across codebase
Migrate all slog error logging from ad-hoc "error", err key-value pairs
to the standardized errors.Attr(err) helper, enabling the exception log
handler to enrich these logs with OTel semantic convention attributes.
* refactor: enforce attr-only slog style across codebase
Change sloglint from kv-only to attr-only, requiring all slog calls to
use typed attributes (slog.String, slog.Any, etc.) instead of key-value
pairs. Convert all existing kv-style slog calls in non-excluded paths.
* refactor: tighten slog.Any to specific types and standardize error attrs
- Replace slog.Any with slog.String for string values (action, key, where_clause)
- Replace slog.Any with slog.Uint64 for uint64 values (start, end, step, etc.)
- Replace slog.Any("err", err) with errors.Attr(err) in dispatcher and segment analytics
- Replace slog.Any("error", ctx.Err()) with errors.Attr in factory registry
* fix(instrumentation): use Unwrapb message for exception.message
Use the explicit error message (m) from Unwrapb instead of
foundErr.Error(), which resolves to the inner cause's message
for wrapped errors.
* feat(errors): capture stacktrace at error creation time
Store program counters ([]uintptr) in base errors at creation time
using runtime.Callers, inspired by thanos-io/thanos/pkg/errors. The
exception log handler reads the stacktrace from the error instead of
capturing at log time, showing where the error originated.
* fix(instrumentation): apply default log wrappers uniformly in NewLogger
Move correlation, filtering, and exception wrappers into NewLogger so
all call sites (including CLI loggers in cmd/) get them automatically.
* refactor(instrumentation): remove variadic wrappers from NewLogger
NewLogger no longer accepts arbitrary wrappers. The core wrappers
(correlation, filtering, exception) are hardcoded, preventing callers
from accidentally duplicating behavior.
* refactor: migrate remaining "error", <var> to errors.Attr across legacy paths
Replace all remaining "error", <variable> key-value pairs with
errors.Attr(<variable>) in pkg/query-service/ and ee/query-service/
paths that were missed in the initial migration due to non-standard
variable names (res.Err, filterErr, apiErrorObj.Err, etc).
* refactor(instrumentation): use flat exception.* keys instead of nested group
Use flat keys (exception.type, exception.code, exception.message,
exception.stacktrace) instead of a nested slog.Group in the exception
log handler.
157 lines
4.8 KiB
Go
157 lines
4.8 KiB
Go
package segmentanalytics
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
|
|
"github.com/SigNoz/signoz/pkg/analytics"
|
|
"github.com/SigNoz/signoz/pkg/errors"
|
|
"github.com/SigNoz/signoz/pkg/factory"
|
|
"github.com/SigNoz/signoz/pkg/types/analyticstypes"
|
|
segment "github.com/segmentio/analytics-go/v3"
|
|
)
|
|
|
|
type provider struct {
|
|
settings factory.ScopedProviderSettings
|
|
client segment.Client
|
|
stopC chan struct{}
|
|
}
|
|
|
|
func NewFactory() factory.ProviderFactory[analytics.Analytics, analytics.Config] {
|
|
return factory.NewProviderFactory(factory.MustNewName("segment"), New)
|
|
}
|
|
|
|
func New(ctx context.Context, providerSettings factory.ProviderSettings, config analytics.Config) (analytics.Analytics, error) {
|
|
settings := factory.NewScopedProviderSettings(providerSettings, "github.com/SigNoz/signoz/pkg/analytics/segmentanalytics")
|
|
|
|
client, err := segment.NewWithConfig(config.Segment.Key, segment.Config{
|
|
Logger: newSegmentLogger(settings),
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &provider{
|
|
settings: settings,
|
|
client: client,
|
|
stopC: make(chan struct{}),
|
|
}, nil
|
|
}
|
|
|
|
func (provider *provider) Start(_ context.Context) error {
|
|
<-provider.stopC
|
|
return nil
|
|
}
|
|
|
|
func (provider *provider) Send(ctx context.Context, messages ...analyticstypes.Message) {
|
|
for _, message := range messages {
|
|
err := provider.client.Enqueue(message)
|
|
if err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to send message to segment", errors.Attr(err))
|
|
}
|
|
}
|
|
}
|
|
|
|
func (provider *provider) TrackGroup(ctx context.Context, group, event string, properties map[string]any) {
|
|
if properties == nil {
|
|
provider.settings.Logger().WarnContext(ctx, "empty attributes received, skipping event", slog.String("group", group), slog.String("event", event))
|
|
return
|
|
}
|
|
|
|
err := provider.client.Enqueue(analyticstypes.Track{
|
|
UserId: "stats_" + group,
|
|
Event: event,
|
|
Properties: analyticstypes.NewPropertiesFromMap(properties),
|
|
Context: &analyticstypes.Context{
|
|
Extra: map[string]interface{}{
|
|
analyticstypes.KeyGroupID: group,
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to send message to segment", errors.Attr(err))
|
|
}
|
|
}
|
|
|
|
func (provider *provider) TrackUser(ctx context.Context, group, user, event string, properties map[string]any) {
|
|
if properties == nil {
|
|
provider.settings.Logger().WarnContext(ctx, "empty attributes received, skipping event", slog.String("user", user), slog.String("group", group), slog.String("event", event))
|
|
return
|
|
}
|
|
|
|
err := provider.client.Enqueue(analyticstypes.Track{
|
|
UserId: user,
|
|
Event: event,
|
|
Properties: analyticstypes.NewPropertiesFromMap(properties),
|
|
Context: &analyticstypes.Context{
|
|
Extra: map[string]interface{}{
|
|
analyticstypes.KeyGroupID: group,
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to send message to segment", errors.Attr(err))
|
|
}
|
|
}
|
|
|
|
func (provider *provider) IdentifyGroup(ctx context.Context, group string, traits map[string]any) {
|
|
if traits == nil {
|
|
provider.settings.Logger().WarnContext(ctx, "empty attributes received, skipping identify", slog.String("group", group))
|
|
return
|
|
}
|
|
|
|
// identify the user
|
|
err := provider.client.Enqueue(analyticstypes.Identify{
|
|
UserId: "stats_" + group,
|
|
Traits: analyticstypes.NewTraitsFromMap(traits),
|
|
})
|
|
if err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to send message to segment", errors.Attr(err))
|
|
}
|
|
|
|
// identify the group using the stats user
|
|
err = provider.client.Enqueue(analyticstypes.Group{
|
|
UserId: "stats_" + group,
|
|
GroupId: group,
|
|
Traits: analyticstypes.NewTraitsFromMap(traits),
|
|
})
|
|
if err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to send message to segment", errors.Attr(err))
|
|
}
|
|
}
|
|
|
|
func (provider *provider) IdentifyUser(ctx context.Context, group, user string, traits map[string]any) {
|
|
if traits == nil {
|
|
provider.settings.Logger().WarnContext(ctx, "empty attributes received, skipping identify", slog.String("user", user), slog.String("group", group))
|
|
return
|
|
}
|
|
|
|
// identify the user
|
|
err := provider.client.Enqueue(analyticstypes.Identify{
|
|
UserId: user,
|
|
Traits: analyticstypes.NewTraitsFromMap(traits),
|
|
})
|
|
if err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to send message to segment", errors.Attr(err))
|
|
}
|
|
|
|
// associate the user with the group
|
|
err = provider.client.Enqueue(analyticstypes.Group{
|
|
UserId: user,
|
|
GroupId: group,
|
|
Traits: analyticstypes.NewTraits().Set("id", group), // A trait is required
|
|
})
|
|
if err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to send message to segment", errors.Attr(err))
|
|
}
|
|
}
|
|
|
|
func (provider *provider) Stop(ctx context.Context) error {
|
|
if err := provider.client.Close(); err != nil {
|
|
provider.settings.Logger().WarnContext(ctx, "unable to close segment client", errors.Attr(err))
|
|
}
|
|
|
|
close(provider.stopC)
|
|
return nil
|
|
}
|