mirror of
https://github.com/SigNoz/signoz.git
synced 2026-09-28 14:20:42 +01:00
720810d424
#### Description - Quick filters sidebar scrolls the whole page instead of scrolling itself, so the top nav, module tabs and the table scroll away with it. Happens on traces, llm observability, api monitoring, exceptions and meter.. logs is the only page behaving today. - Cause is antd Tabs.. it never passes height down to the tab pane, and every module page wrapped `RouteTab` in a plain div, so the page inside was never bounded. Pages that wanted their own scroll each kept a private copy of the same `.ant-tabs` override, traces and meter never had one. - `RouteTab` now owns the height chain and scrolls each pane's content, so the tab bar stays put on every tabbed page. Module pages pass their class to `RouteTab` instead of wrapping it, and the six copied overrides are gone. - New `QuickFiltersLayout` gives the explorer pages a bounded two pane layout.. 280px sidebar that scrolls itself, content that scrolls itself. Traces, llm, api monitoring, exceptions and meter are on it now. - Logs and infra are unchanged here, both move to the shared layout in follow ups. - Also drops the per page viewport heights on the quick filter settings drawer.. with the pane bounded, `height: 100%` is enough, and the save/discard footer stays reachable with the banners on. #### Issues closed by this PR Closes https://github.com/SigNoz/engineering-pod/issues/6088 Closes https://github.com/SigNoz/engineering-pod/issues/6104 Part of https://github.com/SigNoz/engineering-pod/issues/5946 #### Screenshots/ recordings Banner fix [BEFORE] https://github.com/user-attachments/assets/44bc98f8-7ce9-45a7-9c45-e86648c40f69 Banner fix [AFTER] https://github.com/user-attachments/assets/c1140a2a-f00e-4685-87e4-4a0f5d72623a Quick Filter Whole Page scroll Fix [BEFORE] https://github.com/user-attachments/assets/07bd42a0-db80-4d14-bf8a-bcea01fb70b1 [AFTER] https://github.com/user-attachments/assets/7bd14951-2595-43cd-8eab-dcb57cdce011 #### Additional Information - The `RouteTab` change touches every tabbed page, not just the quick filter ones. Checked traces, logs, exceptions, api monitoring, meter, infra hosts, metrics summary, funnels, saved views, pipelines, mq, logs settings, settings (org + members) and alert details, with the trial banner on and off. llm observability is feature gated on my instance so it is not checked in the browser. - Behaviour change to call out: top nav and tab bar are now fixed on all tabbed pages. Pages that mount `RouteTab` inside a block wrapper (alert details, the exceptions inner tabs) are unaffected, the scroller is inert there. - Sidebar is 280px everywhere now, was a 260/280 mix. - Pane content that needs a bounded box should size with `height: 100%`.. `flex: 1` does nothing inside the scroller viewport (documented on `RouteTab`). - cc. @H4ad
18 lines
260 B
SCSS
18 lines
260 B
SCSS
.logs-module-container {
|
|
.ant-tabs-nav {
|
|
padding: 0 16px;
|
|
margin-bottom: 0px;
|
|
|
|
&::before {
|
|
border-bottom: 1px solid var(--l1-border) !important;
|
|
}
|
|
}
|
|
|
|
.tab-item {
|
|
display: flex;
|
|
justify-content: center;
|
|
align-items: center;
|
|
gap: 8px;
|
|
}
|
|
}
|