mirror of
https://github.com/SigNoz/signoz.git
synced 2026-08-17 10:20:31 +01:00
16849967c5
Some checks failed
build-staging / prepare (push) Has been cancelled
build-staging / js-build (push) Has been cancelled
build-staging / go-build (push) Has been cancelled
build-staging / staging (push) Has been cancelled
cacheci / tests (push) Has been cancelled
Release Drafter / update_release_draft (push) Has been cancelled
#### Description Stacked on SigNoz/signoz#12491 — review that one first. #12491 makes the frontend parser lex and parse `search()`. This makes the editor act on it. Scoped to `search('x')` and `search(x)` for now — scope arguments are not handled yet. - **Function suggestion.** The cursor on `search` resolved to no context, so the suggestion list never opened and `search()` was never offered as a completion. Registered alongside the `has` family, in the same two places `hasToken` needed. - **The term is free text, not a key.** `search(x)` lexes its term as a key, so the editor offered attribute keys inside the call and would complete one into the term — and pair extraction turned it into a filter item keyed `x`, which the log detail drawer rebuilds into a real filter. Key and value suggestions are now suppressed inside a `search()` call, and its argument no longer produces a pair. `has(key, value)` does take a real key, so its suggestions are untouched. - **Logs only.** `FilterOperatorSearch` is implemented in `logstelemetryschema` alone; traces and metrics reject it as an unsupported operator, so the suggestion is gated to the logs signal. - **Recents.** `SEARCH(...)` and `search(...)` no longer dedup as two distinct recent queries. #### Additional Information `search` is a reserved word now, so `search = 'x'` and `search exists` no longer parse — the same tradeoff `has`/`hasAny` already carry, matching the backend grammar. Three things deliberately left out: - After picking any function from the autocomplete the cursor lands outside the brackets, so you have to arrow back before typing the argument. Long-standing behaviour across the whole `has` family, but `search()` is the case where an empty call is always a syntax error. Filed as SigNoz/engineering-pod#5893. - `has(key, value)` still contributes a phantom filter item keyed on its first argument, which reaches the trace waterfall's API query, the metrics drilldown and the infra filter telemetry. Fixing it needs the autocomplete to keep reading that argument as a key, so it is not a one-liner. - Scope arguments (`search('err', body)`) parse but are not supported here. `isCursorInSearchTerm` runs on every cursor move, so it text-matches `search` before paying for a lex. A `SEARCH` token only exists where the lexer matched exactly those six letters — a word character on either side would have produced a `KEY` — so the pre-check cannot produce a false negative. `body = 'search this'` is covered by a test, since only the lexer can tell that one is a quoted value. Unrelated to this PR: `QuerySearch.test.tsx › fetches key suggestions on mount for LOGS` is flaky on `main` too. An earlier test in that file types `http.` and never unmounts, so its debounced `getKeySuggestions` resolves after this test's `mockClear()` and wins the `mock.calls[length - 1]` read.