mirror of
https://github.com/SigNoz/signoz.git
synced 2026-06-08 18:10:27 +01:00
e75a0b59d6
Some checks failed
build-staging / prepare (push) Has been cancelled
build-staging / js-build (push) Has been cancelled
build-staging / go-build (push) Has been cancelled
build-staging / staging (push) Has been cancelled
Release Drafter / update_release_draft (push) Has been cancelled
* feat(rules): use alertmanager external URL for related logs/traces and generator URL Plumbs SIGNOZ_ALERTMANAGER_SIGNOZ_EXTERNAL__URL through the rule manager so the host portion of related_logs / related_traces come from configured external URL instead of the frontend window.location captured at rule-creation time. Frontend-supplied source URL is retained as a fallback when the env var has not been set so existing self-hosted deployments keep working. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(rules)!: drop frontend source URL fallback for related logs/traces and generator URL Always derive the host portion of the rule generator URL and the related_logs / related_traces annotations from SIGNOZ_ALERTMANAGER_SIGNOZ_EXTERNAL__URL. Self-hosted deployments that have not set the env var will see the default (http://localhost:8080) in alert notifications, which makes the need to configure it surface clearly. Revert this commit to restore the prior fallback behavior. Refs SigNoz/engineering-pod#5055 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor: simplify ExternalURLHost * chore: use alert overview url for generator url * refactor(rules): source external URL via alertmanager.Config() instead of plumbing through main Address PR feedback (therealpandey): expose a Config() accessor on the alertmanager.Alertmanager interface and consume the external URL from it inside signozruler.NewFactory. This drops the *url.URL parameter that was previously threaded through cmd/community/server.go, cmd/enterprise/server.go, and pkg/signoz/signoz.go. Also switch BaseRule.GeneratorURL to *url.URL.JoinPath + Query so the URL is composed correctly when the external URL carries a base path (e.g. https://signoz.example.com/signoz) and ruleId is properly query-encoded, as suggested in review. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor: expose alertmanagerserver.Config * refactor: rename "linksTo" to "paramsFor" --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>