mirror of
https://github.com/SigNoz/signoz.git
synced 2026-08-02 11:20:35 +01:00
08715a704a
Some checks failed
build-staging / prepare (push) Has been cancelled
build-staging / js-build (push) Has been cancelled
build-staging / go-build (push) Has been cancelled
build-staging / staging (push) Has been cancelled
Release Drafter / update_release_draft (push) Has been cancelled
* feat(rulestatehistory): populate related logs/traces links in v2 history APIs The v2 rule history timeline dropped the relatedLogsLink/relatedTracesLink that v1 (getRuleStateHistory) returned per entry, which the alert history page uses to jump from a state change to the explorer with the rule's filter and the entry's labels. Load the rule from the rule store in the module and build the links with contextlinks, scoped to the entry's evaluation window like v1. Extract the builder-query filter/group-by selection that the v1 handler and threshold rule notifications each inlined into contextlinks.BuilderQueryForSignal and reuse it from both the module and ThresholdRule. Also populate the links for top contributors, which both v1 (since #10760) and v2 returned as always-empty fields even though the UI renders them; contributor links span the queried range since the counts aggregate it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(contextlinks): remove unused v3 link helpers PrepareLinksToTraces, PrepareLinksToLogs and PrepareFilters lost their last callers when the deprecated v3/v4 rule support was removed in #10760; the v5 equivalents (PrepareParamsFor*V5 and PrepareFilterExpression) are what all remaining callers use. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: end doc comments with a period to satisfy godot Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(alerts): cover v2 rule history related links for logs and traces Each test fires a rule with a filter and a service.name group-by, then asserts the recorded firing entry and top contributor carry a related explorer link for the rule's signal only, with the label-rewritten filter expression, the evaluation window on timeline entries and the queried range on contributors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(contextlinks): shrink explorer links to the minimal payload The explorer pages read only the data source and filter expression from a shared link and fill in the rest of the query shape with defaults, so stop shipping the v3 builder-query ceremony (queryName, aggregateOperator, aggregateAttribute, stepInterval, paging fields) and the timeRange and options params nothing reads. Links shrink from ~1.2k to ~450 chars and contextlinks no longer depends on the v3 model. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(rulestatehistory): derive link windows from the evaluation envelope Rules created through the current UI store the window in the v2alpha1 evaluation envelope with no top-level evalWindow, so the previous 5m fallback produced wrong link windows for any non-default rolling window and could not represent cumulative windows at all. Use the envelope's NextWindowFor like the rule engine does, keeping the top-level evalWindow (default 5m) as the fallback for rules without an envelope. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(contextlinks): simplify double-encoding comment Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(alerts): use literal matchType/op in fixtures and drop link unit tests Replace the numeric matchType/op codes in all alert scenario fixtures with their literal forms (at_least_once, above, ...) which the API normalizes to the same canonical values, and remove the rule history link unit tests since the integration tests cover the behavior end-to-end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(alerts): move rule history helpers into the shared alerts fixtures Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>