mirror of
https://github.com/SigNoz/signoz.git
synced 2026-08-05 12:40:46 +01:00
44828b4185
Some checks failed
build-staging / js-build (push) Has been cancelled
build-staging / prepare (push) Has been cancelled
build-staging / go-build (push) Has been cancelled
build-staging / staging (push) Has been cancelled
Release Drafter / update_release_draft (push) Has been cancelled
* chore(deps): bump clickhouse-sql-parser to v0.5.2 The parser hangs in an infinite loop on an unterminated block comment and panics on a settings clause with no value, both reachable from user-authored SQL. v0.5.2 fixes those, along with Accept and Walk missing AST children, which anything walking the tree to inspect a query depends on. String() on Expr is gone in favour of FormatSQL, so the callers that rendered a node back to SQL now go through the Format helper, which formats compactly the way String() did. * test(querierlogs): cover the rate aggregation family rate and rate_sum divide by the query window rather than the step, and nothing exercised that path, so a change to how the aggregation expression is rendered would have gone unnoticed. Assert both against the inserted logs. The window is now passed to the request helper instead of relying on its default, since these are the only assertions in the file that depend on it. * test(querierlogs): match the response rounding for rate expectations Scalar responses round floats to three significant figures below one, and the rates are the only values in this test that do not divide evenly, so compare against the rounded form rather than the exact quotient. * test(queriertraces): cover the rate aggregation family Traces derives the scalar rate window separately from logs, so a divergence between the two would go unnoticed with only the logs case. rate_sum here is taken over the intrinsic duration column, which also puts it on the other side of the response rounding boundary from the logs test.