mirror of
https://github.com/SigNoz/signoz.git
synced 2026-08-13 16:30:36 +01:00
fe94b817db
## Pull Request --- ### 📄 Summary Currently, builder and clickhouse queries remove NaN and Inf values, but PromQL does not. This way, it ends up in the final response. While the UI handles these values, a lot of other places in the flow do not, such as our query response caching. This can lead to unexpected issues. The current issue at hand is that while the first query range call shows the correct data, the second call (that fetches from cache) does not. Instead of fixing the caching, better to solve the problem at root level and not return non-finite values for PromQL altogether. #### Recordings On local data before the change: https://github.com/user-attachments/assets/c08ec796-a7e5-47d8-8cc5-3dfd302dba49 After the change: https://github.com/user-attachments/assets/9162c963-1a98-4ebc-83ce-759a9127b772 #### Issues closed by this PR Closes https://github.com/SigNoz/pulse-pod/issues/185 --- ### 🧪 Testing Strategy - Tests added/updated: Yes, integration and unit tests - Manual verification: Added data locally to reproduce the exact scenario --- ### ⚠️ Risk & Impact Assessment - Blast radius: PromQL queries - Rollback plan: Revert PR or just add a fix ---