mirror of
https://github.com/SigNoz/signoz.git
synced 2026-03-24 21:30:26 +00:00
Some checks failed
build-staging / prepare (push) Has been cancelled
build-staging / js-build (push) Has been cancelled
build-staging / go-build (push) Has been cancelled
build-staging / staging (push) Has been cancelled
Release Drafter / update_release_draft (push) Has been cancelled
* feat(instrumentation): add OTel exception semantic convention log handler
Add a loghandler.Wrapper that enriches error log records with OpenTelemetry
exception semantic convention attributes (exception.type, exception.code,
exception.message, exception.stacktrace).
- Add errors.Attr() helper for standardized error logging under "exception" key
- Add exception log handler that replaces raw error attrs with structured group
- Wire exception handler into the instrumentation SDK logger chain
- Remove LogValue() from errors.base as the handler now owns structuring
* refactor: replace "error", err with errors.Attr(err) across codebase
Migrate all slog error logging from ad-hoc "error", err key-value pairs
to the standardized errors.Attr(err) helper, enabling the exception log
handler to enrich these logs with OTel semantic convention attributes.
* refactor: enforce attr-only slog style across codebase
Change sloglint from kv-only to attr-only, requiring all slog calls to
use typed attributes (slog.String, slog.Any, etc.) instead of key-value
pairs. Convert all existing kv-style slog calls in non-excluded paths.
* refactor: tighten slog.Any to specific types and standardize error attrs
- Replace slog.Any with slog.String for string values (action, key, where_clause)
- Replace slog.Any with slog.Uint64 for uint64 values (start, end, step, etc.)
- Replace slog.Any("err", err) with errors.Attr(err) in dispatcher and segment analytics
- Replace slog.Any("error", ctx.Err()) with errors.Attr in factory registry
* fix(instrumentation): use Unwrapb message for exception.message
Use the explicit error message (m) from Unwrapb instead of
foundErr.Error(), which resolves to the inner cause's message
for wrapped errors.
* feat(errors): capture stacktrace at error creation time
Store program counters ([]uintptr) in base errors at creation time
using runtime.Callers, inspired by thanos-io/thanos/pkg/errors. The
exception log handler reads the stacktrace from the error instead of
capturing at log time, showing where the error originated.
* fix(instrumentation): apply default log wrappers uniformly in NewLogger
Move correlation, filtering, and exception wrappers into NewLogger so
all call sites (including CLI loggers in cmd/) get them automatically.
* refactor(instrumentation): remove variadic wrappers from NewLogger
NewLogger no longer accepts arbitrary wrappers. The core wrappers
(correlation, filtering, exception) are hardcoded, preventing callers
from accidentally duplicating behavior.
* refactor: migrate remaining "error", <var> to errors.Attr across legacy paths
Replace all remaining "error", <variable> key-value pairs with
errors.Attr(<variable>) in pkg/query-service/ and ee/query-service/
paths that were missed in the initial migration due to non-standard
variable names (res.Err, filterErr, apiErrorObj.Err, etc).
* refactor(instrumentation): use flat exception.* keys instead of nested group
Use flat keys (exception.type, exception.code, exception.message,
exception.stacktrace) instead of a nested slog.Group in the exception
log handler.
244 lines
6.5 KiB
Go
244 lines
6.5 KiB
Go
package sqlitesqlschema
|
|
|
|
import (
|
|
"context"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/uptrace/bun"
|
|
|
|
"github.com/SigNoz/signoz/pkg/errors"
|
|
"github.com/SigNoz/signoz/pkg/factory"
|
|
"github.com/SigNoz/signoz/pkg/sqlschema"
|
|
"github.com/SigNoz/signoz/pkg/sqlstore"
|
|
)
|
|
|
|
type provider struct {
|
|
settings factory.ScopedProviderSettings
|
|
fmter sqlschema.SQLFormatter
|
|
sqlstore sqlstore.SQLStore
|
|
operator sqlschema.SQLOperator
|
|
}
|
|
|
|
func NewFactory(sqlstore sqlstore.SQLStore) factory.ProviderFactory[sqlschema.SQLSchema, sqlschema.Config] {
|
|
return factory.NewProviderFactory(factory.MustNewName("sqlite"), func(ctx context.Context, providerSettings factory.ProviderSettings, config sqlschema.Config) (sqlschema.SQLSchema, error) {
|
|
return New(ctx, providerSettings, config, sqlstore)
|
|
})
|
|
}
|
|
|
|
func New(ctx context.Context, providerSettings factory.ProviderSettings, config sqlschema.Config, sqlstore sqlstore.SQLStore) (sqlschema.SQLSchema, error) {
|
|
settings := factory.NewScopedProviderSettings(providerSettings, "github.com/SigNoz/signoz/pkg/sqlschema/sqlitesqlschema")
|
|
fmter := Formatter{sqlschema.NewFormatter(sqlstore.BunDB().Dialect())}
|
|
|
|
return &provider{
|
|
fmter: fmter,
|
|
settings: settings,
|
|
sqlstore: sqlstore,
|
|
operator: sqlschema.NewOperator(fmter, sqlschema.OperatorSupport{
|
|
SCreateAndDropConstraint: false,
|
|
SAlterTableAddAndDropColumnIfNotExistsAndExists: false,
|
|
SAlterTableAlterColumnSetAndDrop: false,
|
|
}),
|
|
}, nil
|
|
}
|
|
|
|
func (provider *provider) Formatter() sqlschema.SQLFormatter {
|
|
return provider.fmter
|
|
}
|
|
|
|
func (provider *provider) Operator() sqlschema.SQLOperator {
|
|
return provider.operator
|
|
}
|
|
|
|
func (provider *provider) GetTable(ctx context.Context, tableName sqlschema.TableName) (*sqlschema.Table, []*sqlschema.UniqueConstraint, error) {
|
|
var sql string
|
|
|
|
if err := provider.
|
|
sqlstore.
|
|
BunDB().
|
|
NewRaw("SELECT sql FROM sqlite_master WHERE type IN (?) AND tbl_name = ? AND sql IS NOT NULL", bun.In([]string{"table"}), string(tableName)).
|
|
Scan(ctx, &sql); err != nil {
|
|
return nil, nil, provider.sqlstore.WrapNotFoundErrf(err, errors.CodeNotFound, "table (%s) not found", tableName)
|
|
}
|
|
|
|
table, uniqueConstraints, err := parseCreateTable(sql, provider.fmter)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
return table, uniqueConstraints, nil
|
|
}
|
|
|
|
func (provider *provider) GetIndices(ctx context.Context, tableName sqlschema.TableName) ([]sqlschema.Index, error) {
|
|
rows, err := provider.
|
|
sqlstore.
|
|
BunDB().
|
|
QueryContext(ctx, "SELECT * FROM PRAGMA_index_list(?)", string(tableName))
|
|
if err != nil {
|
|
return nil, provider.sqlstore.WrapNotFoundErrf(err, errors.CodeNotFound, "no indices for table (%s) found", tableName)
|
|
}
|
|
|
|
defer func() {
|
|
if err := rows.Close(); err != nil {
|
|
provider.settings.Logger().ErrorContext(ctx, "error closing rows", errors.Attr(err))
|
|
}
|
|
}()
|
|
|
|
indices := []sqlschema.Index{}
|
|
for rows.Next() {
|
|
var (
|
|
seq int
|
|
name string
|
|
unique bool
|
|
origin string
|
|
partial bool
|
|
columns []sqlschema.ColumnName
|
|
)
|
|
if err := rows.Scan(&seq, &name, &unique, &origin, &partial); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// skip the index that was created by a UNIQUE constraint
|
|
if origin == "u" {
|
|
continue
|
|
}
|
|
|
|
// skip the index that was created by primary key constraint
|
|
if origin == "pk" {
|
|
continue
|
|
}
|
|
|
|
if err := provider.
|
|
sqlstore.
|
|
BunDB().
|
|
NewRaw("SELECT name FROM PRAGMA_index_info(?)", string(name)).
|
|
Scan(ctx, &columns); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if unique && partial {
|
|
var indexSQL string
|
|
if err := provider.
|
|
sqlstore.
|
|
BunDB().
|
|
NewRaw("SELECT sql FROM sqlite_master WHERE type = 'index' AND name = ?", name).
|
|
Scan(ctx, &indexSQL); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
where := extractWhereClause(indexSQL)
|
|
index := &sqlschema.PartialUniqueIndex{
|
|
TableName: tableName,
|
|
ColumnNames: columns,
|
|
Where: where,
|
|
}
|
|
|
|
if index.Name() == name {
|
|
indices = append(indices, index)
|
|
} else {
|
|
indices = append(indices, index.Named(name))
|
|
}
|
|
} else if unique {
|
|
index := &sqlschema.UniqueIndex{
|
|
TableName: tableName,
|
|
ColumnNames: columns,
|
|
}
|
|
|
|
if index.Name() == name {
|
|
indices = append(indices, index)
|
|
} else {
|
|
indices = append(indices, index.Named(name))
|
|
}
|
|
}
|
|
}
|
|
|
|
return indices, nil
|
|
}
|
|
|
|
func (provider *provider) ToggleFKEnforcement(ctx context.Context, db bun.IDB, on bool) error {
|
|
_, err := db.ExecContext(ctx, "PRAGMA foreign_keys = ?", on)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var val bool
|
|
if err := db.NewRaw("PRAGMA foreign_keys").Scan(ctx, &val); err != nil {
|
|
return err
|
|
}
|
|
|
|
if on == val {
|
|
return nil
|
|
}
|
|
|
|
return errors.NewInternalf(errors.CodeInternal, "foreign_keys(actual: %s, expected: %s), maybe a transaction is in progress?", strconv.FormatBool(val), strconv.FormatBool(on))
|
|
}
|
|
|
|
func extractWhereClause(sql string) string {
|
|
lastWhere := -1
|
|
inSingleQuotedLiteral := false
|
|
inDoubleQuotedIdentifier := false
|
|
inBacktickQuotedIdentifier := false
|
|
inBracketQuotedIdentifier := false
|
|
|
|
for i := 0; i < len(sql); i++ {
|
|
switch sql[i] {
|
|
case '\'':
|
|
if inDoubleQuotedIdentifier || inBacktickQuotedIdentifier || inBracketQuotedIdentifier {
|
|
continue
|
|
}
|
|
if inSingleQuotedLiteral && i+1 < len(sql) && sql[i+1] == '\'' {
|
|
i++
|
|
continue
|
|
}
|
|
inSingleQuotedLiteral = !inSingleQuotedLiteral
|
|
case '"':
|
|
if inSingleQuotedLiteral || inBacktickQuotedIdentifier || inBracketQuotedIdentifier {
|
|
continue
|
|
}
|
|
if inDoubleQuotedIdentifier && i+1 < len(sql) && sql[i+1] == '"' {
|
|
i++
|
|
continue
|
|
}
|
|
inDoubleQuotedIdentifier = !inDoubleQuotedIdentifier
|
|
case '`':
|
|
if inSingleQuotedLiteral || inDoubleQuotedIdentifier || inBracketQuotedIdentifier {
|
|
continue
|
|
}
|
|
inBacktickQuotedIdentifier = !inBacktickQuotedIdentifier
|
|
case '[':
|
|
if inSingleQuotedLiteral || inDoubleQuotedIdentifier || inBacktickQuotedIdentifier || inBracketQuotedIdentifier {
|
|
continue
|
|
}
|
|
inBracketQuotedIdentifier = true
|
|
case ']':
|
|
if inBracketQuotedIdentifier {
|
|
inBracketQuotedIdentifier = false
|
|
}
|
|
}
|
|
|
|
if inSingleQuotedLiteral || inDoubleQuotedIdentifier || inBacktickQuotedIdentifier || inBracketQuotedIdentifier {
|
|
continue
|
|
}
|
|
|
|
if strings.EqualFold(sql[i:min(i+5, len(sql))], "WHERE") &&
|
|
(i == 0 || !isSQLiteIdentifierChar(sql[i-1])) &&
|
|
(i+5 == len(sql) || !isSQLiteIdentifierChar(sql[i+5])) {
|
|
lastWhere = i
|
|
i += 4
|
|
}
|
|
}
|
|
|
|
if lastWhere == -1 {
|
|
return ""
|
|
}
|
|
|
|
return strings.TrimSpace(sql[lastWhere+len("WHERE"):])
|
|
}
|
|
|
|
func isSQLiteIdentifierChar(ch byte) bool {
|
|
return (ch >= 'a' && ch <= 'z') ||
|
|
(ch >= 'A' && ch <= 'Z') ||
|
|
(ch >= '0' && ch <= '9') ||
|
|
ch == '_'
|
|
}
|