mirror of
https://github.com/SigNoz/signoz.git
synced 2026-03-28 15:10:29 +00:00
Some checks failed
build-staging / prepare (push) Has been cancelled
build-staging / js-build (push) Has been cancelled
build-staging / go-build (push) Has been cancelled
build-staging / staging (push) Has been cancelled
Release Drafter / update_release_draft (push) Has been cancelled
* feat(instrumentation): add OTel exception semantic convention log handler
Add a loghandler.Wrapper that enriches error log records with OpenTelemetry
exception semantic convention attributes (exception.type, exception.code,
exception.message, exception.stacktrace).
- Add errors.Attr() helper for standardized error logging under "exception" key
- Add exception log handler that replaces raw error attrs with structured group
- Wire exception handler into the instrumentation SDK logger chain
- Remove LogValue() from errors.base as the handler now owns structuring
* refactor: replace "error", err with errors.Attr(err) across codebase
Migrate all slog error logging from ad-hoc "error", err key-value pairs
to the standardized errors.Attr(err) helper, enabling the exception log
handler to enrich these logs with OTel semantic convention attributes.
* refactor: enforce attr-only slog style across codebase
Change sloglint from kv-only to attr-only, requiring all slog calls to
use typed attributes (slog.String, slog.Any, etc.) instead of key-value
pairs. Convert all existing kv-style slog calls in non-excluded paths.
* refactor: tighten slog.Any to specific types and standardize error attrs
- Replace slog.Any with slog.String for string values (action, key, where_clause)
- Replace slog.Any with slog.Uint64 for uint64 values (start, end, step, etc.)
- Replace slog.Any("err", err) with errors.Attr(err) in dispatcher and segment analytics
- Replace slog.Any("error", ctx.Err()) with errors.Attr in factory registry
* fix(instrumentation): use Unwrapb message for exception.message
Use the explicit error message (m) from Unwrapb instead of
foundErr.Error(), which resolves to the inner cause's message
for wrapped errors.
* feat(errors): capture stacktrace at error creation time
Store program counters ([]uintptr) in base errors at creation time
using runtime.Callers, inspired by thanos-io/thanos/pkg/errors. The
exception log handler reads the stacktrace from the error instead of
capturing at log time, showing where the error originated.
* fix(instrumentation): apply default log wrappers uniformly in NewLogger
Move correlation, filtering, and exception wrappers into NewLogger so
all call sites (including CLI loggers in cmd/) get them automatically.
* refactor(instrumentation): remove variadic wrappers from NewLogger
NewLogger no longer accepts arbitrary wrappers. The core wrappers
(correlation, filtering, exception) are hardcoded, preventing callers
from accidentally duplicating behavior.
* refactor: migrate remaining "error", <var> to errors.Attr across legacy paths
Replace all remaining "error", <variable> key-value pairs with
errors.Attr(<variable>) in pkg/query-service/ and ee/query-service/
paths that were missed in the initial migration due to non-standard
variable names (res.Err, filterErr, apiErrorObj.Err, etc).
* refactor(instrumentation): use flat exception.* keys instead of nested group
Use flat keys (exception.type, exception.code, exception.message,
exception.stacktrace) instead of a nested slog.Group in the exception
log handler.
107 lines
3.0 KiB
Go
107 lines
3.0 KiB
Go
package plugin
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"log/slog"
|
|
"net"
|
|
"net/http"
|
|
|
|
"github.com/gojek/heimdall/v7"
|
|
semconv "go.opentelemetry.io/otel/semconv/v1.27.0"
|
|
|
|
"github.com/SigNoz/signoz/pkg/errors"
|
|
)
|
|
|
|
type reqResLog struct {
|
|
logger *slog.Logger
|
|
}
|
|
|
|
func NewLog(logger *slog.Logger) heimdall.Plugin {
|
|
return &reqResLog{
|
|
logger: logger,
|
|
}
|
|
}
|
|
|
|
func (plugin *reqResLog) OnRequestStart(request *http.Request) {
|
|
host, port, _ := net.SplitHostPort(request.Host)
|
|
fields := []any{
|
|
string(semconv.HTTPRequestMethodKey), request.Method,
|
|
string(semconv.URLPathKey), request.URL.Path,
|
|
string(semconv.URLSchemeKey), request.URL.Scheme,
|
|
string(semconv.UserAgentOriginalKey), request.UserAgent(),
|
|
string(semconv.ServerAddressKey), host,
|
|
string(semconv.ServerPortKey), port,
|
|
string(semconv.HTTPRequestSizeKey), request.ContentLength,
|
|
}
|
|
|
|
// only include all the headers if we are at debug level
|
|
if plugin.logger.Handler().Enabled(request.Context(), slog.LevelDebug) {
|
|
fields = append(fields, "http.request.headers", request.Header)
|
|
} else {
|
|
fields = append(fields, "http.request.headers", redactSensitiveHeaders(request.Header))
|
|
}
|
|
|
|
plugin.logger.InfoContext(request.Context(), "::SENT-REQUEST::", fields...)
|
|
}
|
|
|
|
func (plugin *reqResLog) OnRequestEnd(request *http.Request, response *http.Response) {
|
|
fields := []any{
|
|
string(semconv.HTTPResponseStatusCodeKey), response.StatusCode,
|
|
string(semconv.HTTPResponseBodySizeKey), response.ContentLength,
|
|
}
|
|
|
|
bodybytes, err := io.ReadAll(response.Body)
|
|
if err != nil {
|
|
plugin.logger.DebugContext(request.Context(), "::UNABLE-TO-LOG-RESPONSE-BODY::", errors.Attr(err))
|
|
} else {
|
|
_ = response.Body.Close()
|
|
response.Body = io.NopCloser(bytes.NewBuffer(bodybytes))
|
|
|
|
if len(bodybytes) > 0 {
|
|
fields = append(fields, "http.response.body", string(bodybytes))
|
|
} else {
|
|
fields = append(fields, "http.response.body", "(empty)")
|
|
}
|
|
}
|
|
|
|
plugin.logger.InfoContext(request.Context(), "::RECEIVED-RESPONSE::", fields...)
|
|
}
|
|
|
|
func (plugin *reqResLog) OnError(request *http.Request, err error) {
|
|
host, port, _ := net.SplitHostPort(request.Host)
|
|
fields := []any{
|
|
errors.Attr(err),
|
|
string(semconv.HTTPRequestMethodKey), request.Method,
|
|
string(semconv.URLPathKey), request.URL.Path,
|
|
string(semconv.URLSchemeKey), request.URL.Scheme,
|
|
string(semconv.UserAgentOriginalKey), request.UserAgent(),
|
|
string(semconv.ServerAddressKey), host,
|
|
string(semconv.ServerPortKey), port,
|
|
string(semconv.HTTPRequestSizeKey), request.ContentLength,
|
|
}
|
|
|
|
plugin.logger.ErrorContext(request.Context(), "::UNABLE-TO-SEND-REQUEST::", fields...)
|
|
}
|
|
|
|
func redactSensitiveHeaders(headers http.Header) http.Header {
|
|
// maintained list of headers to redact
|
|
sensitiveHeaders := map[string]bool{
|
|
"Authorization": true,
|
|
"Cookie": true,
|
|
"X-Signoz-Cloud-Api-Key": true,
|
|
}
|
|
|
|
safeHeaders := make(http.Header)
|
|
|
|
for header, value := range headers {
|
|
if sensitiveHeaders[header] {
|
|
safeHeaders[header] = []string{"REDACTED"}
|
|
} else {
|
|
safeHeaders[header] = value
|
|
}
|
|
}
|
|
|
|
return safeHeaders
|
|
}
|