* fix(logs): open log details in table (Column) format when activeId is set
Opening a log link (?activeLogId=...) and switching to Column/table format
left the highlighted row un-openable — clicking it did nothing.
Root cause: the shared TanStackTable decided open vs. close internally from
`isRowActive` + `onRowDeactivate`. LogsExplorerList had overloaded `isRowActive`
with `|| log.id === activeLogId`, so a URL-highlighted-but-closed row looked
"active" and the first click ran the deactivate (close) path instead of opening.
Fix (PR 1 of 2): move click routing to the consumer.
- Remove `onRowDeactivate` from TanStackTable; it took no args and only fired
when re-clicking the same active row (clicking A→B never deactivated A).
- `onRowClick` now receives a third `{ isActive }` context arg (additive; the
~14 existing consumers are unaffected).
- LogsExplorerList and LiveLogsList own the toggle:
`isActive ? handleCloseLogDetail() : handleSetActiveLog(log)`, and
`isRowActive` tracks only `activeLog?.id`.
The linked-row visual highlight (`isHighlighted`) is deferred to PR 2 (blocked
on a design decision for the highlight color); see
frontend/docs/tdd-tanstack-row-click-routing.md.
* feat(logs): highlight the URL-linked (activeLogId) row in table format (#12271)
Restores the linked-row highlight that the TanStack migration (#10946)
dropped from the table view, without coupling it to click routing.
Uses the table's existing `getRowClassName` hook (styling-only) — no new
shared-table prop:
- LogsExplorerList / LiveLogsList set getRowClassName to 'logs-linked-row'
when `log.id === activeLogId`.
- A global, lowest-specificity rule paints `.logs-linked-row td` using the
per-row `--row-active-bg` var (already set via getRowStyle). The table's own
:hover / .tableRowActive cell rules are higher-specificity !important, so
active/hover correctly win when a linked row is also open or hovered.
`isRowActive` stays `activeLog?.id` only, so the highlighted row still opens on
first click (relies on the routing fix in the base PR).
Color reuses --row-active-bg as a placeholder; a distinct "linked" token is a
follow-up pending design.
Co-authored-by: Gaurav Tewari <tewarig@users.noreply.github.com>
* chore: remove comments
* chore: remove extra comments
* feat: add e2e for flows
* chore: add test id
* chore: chore: remove comment
* chore: remove comment
* chore: remove comment
* chore: add comment
* chore: remove comment
---------
Co-authored-by: Gaurav Tewari <tewarig@users.noreply.github.com>
* fix(pods): min width for pod restarts
* fix(disk-usage): not have minimum width correctly
* perf(infra-monitoring-v2): set cache before opening details modal
* feat(tanstack): add custom markers for perf review
* feat(tanstack): add hover tooltip + integrate on infra monitoring
* perf(grouped-status-counts): use tanstack tooltip hover
* fix(k8s-base-list): adding table def to classnames
* perf(grouped-status-counts): reduce node count on DOM
* feat(infrastructure-monitoring): use single component instead of unmount/mount all content
* chore(infrastructure-monitoring-k8s): remove old list components
* fix(hosts): make it double line header
* fix(infrastructure-monitoring): show scrollbar only on hover
* chore(pod-metrics): add docs for charts
* fix(perf-lib): address comments
* fix(infra-monitoring): rename entityConfig to entity.config
* feat(tanstack): add support for itemKey be object
* feat(infra-monitoring): add base structure for multiple selected items
* refactor(infra-monitoring): add cluster for namespaces, cluster/namespace for volumes + update other entities
* refactor(infra-monitoring): add cluster + namespace for statefulsets
* refactor(infra-monitoring): add cluster + namespace for jobs
* refactor(infra-monitoring): add cluster + namespace for deployments
* refactor(infra-monitoring): add cluster + namespace for daemonsets
* test(infra-monitoring): add new tests for changes of k8s base list
* fix(pr): address comments
* feat(infra-monitoring): use new table component
* test(k8s-base-list): try fix issue with flaky test
* fix(table): tweaks in the layout
* fix(pr-comments): usage of const and move disable lint to line
* fix(css): format of css file
* test(k8s-base-list): flaky test
* test(k8s-base-list): second try to fix flaky test
* fix(table): have different ids for expanded table
* fix(k8s-base-list): third attempt to de-flaky test
* refactor(table): tiny adjustments on table
* fix(k8s-empty-state): better title size
* refactor(tanstack): move table to components & convert to css modules
* refactor(table): extract table to own component
* refactor(table): optimize
* chore(tests): cleanup tests and components
* fix(styles): minor fixes on styles
* fix(tests): use find by text
* fix(row): missing active styles
* refactor(tanstack-table): refine component based on infra monitoring
* docs(tanstacktable): add more docs about usage
* refactor(table): cleanup and fixes related to column and old preferences of logs
* refactor(table): more cleanup
* refactor(table): removed deprecated api
* fix(tanstack): more cleanup
* fix(sonner): removed old dependency
* fix(resizing): better resizing support
* fix(tanstack-header-row): use our version of popover
* fix(column-view): remove unused file
* fix(oxlint): alerts and issues
* fix(test): rollback aria-sort and rename to data-sort
