SigNoz/signoz
1
0
Fork 0
mirror of https://github.com/SigNoz/signoz.git synced 2026-09-16 00:10:42 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

refactor(query-suggestions): move fieldSuggestions back under QuerySearch

Browse Source 
Reverts the earlier move to the api layer; the module and its test return to
where they started, and the importers follow.

Assisted-by: Claude Opus 5
This commit is contained in:
Gaurav Tewari
2026-08-27 10:58:37 +05:30
parent 1b4b0f51f4
commit cec074aaf5
7 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/components/OrderBy/ListViewOrderBy.tsx
View File

@@ -5,7 +5,7 @@ import type { TelemetrytypesFieldContextDTO } from 'api/generated/services/sigNo
import {
fetchFieldKeysForQuery,
SuggestedFieldKey,
} from 'api/querySuggestions/fieldSuggestions';
} from 'components/QueryBuilderV2/QueryV2/QuerySearch/fieldSuggestions';
import { IBuilderQuery } from 'types/api/queryBuilder/queryBuilderData';
import { DataSource } from 'types/common/queryBuilder';

11
frontend/src/components/OrderBy/__tests__/ListViewOrderBy.test.tsx
View File

@@ -1,13 +1,16 @@
import { fireEvent, render, screen, waitFor } from 'tests/test-utils';
import { TelemetrytypesFieldContextDTO } from 'api/generated/services/sigNoz.schemas';
import { fetchFieldKeysForQuery } from 'api/querySuggestions/fieldSuggestions';
import { fetchFieldKeysForQuery } from 'components/QueryBuilderV2/QueryV2/QuerySearch/fieldSuggestions';
import { DataSource } from 'types/common/queryBuilder';
import ListViewOrderBy from '../ListViewOrderBy';
jest.mock('api/querySuggestions/fieldSuggestions', () => ({
fetchFieldKeysForQuery: jest.fn(),
}));
jest.mock(
'components/QueryBuilderV2/QueryV2/QuerySearch/fieldSuggestions',
() => ({
fetchFieldKeysForQuery: jest.fn(),
}),
);
const mockedFetchKeys = fetchFieldKeysForQuery as jest.MockedFunction<
typeof fetchFieldKeysForQuery

2
frontend/src/components/QueryBuilderV2/QueryV2/QuerySearch/QuerySearch.tsx
View File

@@ -57,7 +57,7 @@ import {
fetchFieldValuesForQuery,
SuggestedFieldKey,
SuggestedFieldKeysByName,
} from 'api/querySuggestions/fieldSuggestions';
} from './fieldSuggestions';
import {
combineInitialAndUserExpression,
dedupeOptionsByLabel,

0
frontend/src/api/querySuggestions/__tests__/fieldSuggestions.test.ts → frontend/src/components/QueryBuilderV2/QueryV2/QuerySearch/__tests__/fieldSuggestions.test.ts
View File

0
frontend/src/api/querySuggestions/fieldSuggestions.ts → frontend/src/components/QueryBuilderV2/QueryV2/QuerySearch/fieldSuggestions.ts
View File

11
frontend/src/container/LLMObservability/Explorer/TracesView/__tests__/useTraceViewColumns.test.tsx
View File

@@ -3,7 +3,7 @@ import { ReactNode } from 'react';
import { QueryClient, QueryClientProvider } from 'react-query';
import { act, renderHook, waitFor } from '@testing-library/react';
import { TelemetrytypesFieldContextDTO } from 'api/generated/services/sigNoz.schemas';
import { fetchFieldKeysForQuery } from 'api/querySuggestions/fieldSuggestions';
import { fetchFieldKeysForQuery } from 'components/QueryBuilderV2/QueryV2/QuerySearch/fieldSuggestions';
import { useColumnStore } from 'components/TanStackTableView/useColumnStore';
import { LOCALSTORAGE } from 'constants/localStorage';
import { TelemetryFieldKey } from 'types/api/v5/queryRange';
@@ -11,9 +11,12 @@ import { DataSource } from 'types/common/queryBuilder';
import { useTraceViewColumns } from '../useTraceViewColumns';
jest.mock('api/querySuggestions/fieldSuggestions', () => ({
fetchFieldKeysForQuery: jest.fn(),
}));
jest.mock(
'components/QueryBuilderV2/QueryV2/QuerySearch/fieldSuggestions',
() => ({
fetchFieldKeysForQuery: jest.fn(),
}),
);
const mockedFetchKeys = fetchFieldKeysForQuery as jest.MockedFunction<
typeof fetchFieldKeysForQuery

2
frontend/src/hooks/querySuggestions/useSelectableFields.ts
View File

@@ -1,6 +1,6 @@
import { useQuery } from 'react-query';
import { TelemetrytypesFieldContextDTO } from 'api/generated/services/sigNoz.schemas';
import { fetchFieldKeysForQuery } from 'api/querySuggestions/fieldSuggestions';
import { fetchFieldKeysForQuery } from 'components/QueryBuilderV2/QueryV2/QuerySearch/fieldSuggestions';
import { TelemetryFieldKey } from 'types/api/v5/queryRange';
import { DataSource } from 'types/common/queryBuilder';