buildLabel.sh tweaks #352

New Issue

michael · 2026-01-19T18:33:44Z

michael commented

2026-01-19 18:33:44 +00:00

Originally created by @PhillyPhoto on GitHub.

I noticed with the buildLabel.sh script that line 5 is misconfigured. Instead of:

downloadURL=${"https://developer.salesforce.com/media/salesforce-cli/sf/channels/stable/sf-arm64.pkg"}

at minimum is should be:

downloadURL="https://developer.salesforce.com/media/salesforce-cli/sf/channels/stable/sf-arm64.pkg"

to hard code the URL, but ideally:

downloadURL="$1"

to pass the URL to the script properly.

Also, to avoid errors with basename, line 153 should be changed from:

echo $(basename $downloadURL)

to:

echo $(basename "$downloadURL")

Originally created by @PhillyPhoto on GitHub. I noticed with the buildLabel.sh script that line 5 is misconfigured. Instead of: `downloadURL=${"https://developer.salesforce.com/media/salesforce-cli/sf/channels/stable/sf-arm64.pkg"}` at minimum is should be: `downloadURL="https://developer.salesforce.com/media/salesforce-cli/sf/channels/stable/sf-arm64.pkg"` to hard code the URL, but ideally: `downloadURL="$1"` to pass the URL to the script properly. Also, to avoid errors with basename, line 153 should be changed from: `echo $(basename $downloadURL)` to: `echo $(basename "$downloadURL")`

michael added the utils label 2026-01-19 18:33:44 +00:00

michael closed this issue

2026-01-19 18:33:44 +00:00

michael commented

2026-01-19 18:33:45 +00:00

@Theile commented on GitHub:

Thank you. Apparently a commit has included some unintended changes to this script.

@scriptingosx could you take a look at this commit, and revert it or something?
e42258d874 (diff-bbb59fd725e538490e3d875e920aaf1433ed615f985e0e6137638bbdbfd987ba)

@Theile commented on GitHub: Thank you. Apparently a commit has included some unintended changes to this script. @scriptingosx could you take a look at this commit, and revert it or something? https://github.com/Installomator/Installomator/commit/e42258d8745959e943453707694205cba07746fa#diff-bbb59fd725e538490e3d875e920aaf1433ed615f985e0e6137638bbdbfd987ba

michael commented

2026-01-19 18:33:45 +00:00

@scriptingosx commented on GitHub:

You need to create a PR, reverting a commit that far down the tree is not advisable.

@scriptingosx commented on GitHub: You need to create a PR, reverting a commit that far down the tree is not advisable.

michael commented

2026-01-19 18:33:45 +00:00

@scriptingosx commented on GitHub:

Also, to avoid errors with basename, line 153 should be changed from:
echo $(basename $downloadURL)
to:
echo $(basename "$downloadURL")

This is a zsh script. You don't need to double quote every substitution in zsh.

@scriptingosx commented on GitHub: > Also, to avoid errors with basename, line 153 should be changed from: > > ``` > echo $(basename $downloadURL) > ``` > > to: > > ``` > echo $(basename "$downloadURL") > ``` This is a **zsh** script. You don't need to double quote every substitution in zsh.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Installomator/Installomator#352